fix(tools): reject empty ROS service name/type on CallROS2ServiceTool - #832
Closed
Bartok9 wants to merge 1 commit into
Closed
fix(tools): reject empty ROS service name/type on CallROS2ServiceTool#832Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Validate service_name and service_type with require_non_empty_name before writable checks and connector service_call. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Member
|
Covered in #872, min_length=1 on service_name and service_type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate service_name and service_type before writable checks and connector call.
Testing
Claim: bartok
Operator: bartok
Campaign: aerial-drone